Re: [RFC PATCH v2] fs: touch up symlink clean up in lookup
From: Al Viro
Date: Wed Dec 17 2025 - 06:38:10 EST
On Wed, Dec 17, 2025 at 12:23:45PM +0100, Mateusz Guzik wrote:
> Provide links_cleanup_rcu() and links_cleanup_ref() for rcu- and ref-
> walks respectively.
>
> The somewhat misleading drop_links() gets renamed to links_issue_delayed_calls(),
> which spells out what it is actually doing.
IMO the replacement name is worse; it doesn't say anything about
the purpose of those "issued delayed calls", for starters.
> There are no changes in behavior, this however should be less
> error-prone going forward.
I disagree, but at the moment (6:30am here, and I'd been up since 11am yesterday ;-/)
I don't trust my ability to produce coherent detailed reply. I'll reply in detail
once I get some sleep...