Re: [PATCH RFC net-next 2/6] net: phy: add support to set default rules

From: Jijie Shao
Date: Wed Dec 17 2025 - 07:56:06 EST



on 2025/12/16 15:09, Andrew Lunn wrote:
On Mon, Dec 15, 2025 at 08:57:01PM +0800, Jijie Shao wrote:
The node of led need add new property: rules,
and rules can be set as:
BIT(TRIGGER_NETDEV_LINK) | BIT(TRIGGER_NETDEV_RX)
Please could you expand this description. It is not clear to my why it
is needed. OF systems have not needed it so far. What is special about
your hardware?

I hope to configure the default rules.
Currently, the LED does not configure rules during initialization; it uses the default rules in the PHY registers.
I would like to change the default rules during initialization.


Some of our boards have only one LED, and we want to indicate both link and active(TX and RX) status simultaneously.

Thanks,
Jijie Shao


Also, it looks like you are expanding the DT binding, so you need to
update the binding .yaml file.

Andrew