Re: [PATCH] staging: rtl8723bs: clean up redundant parentheses in rtw_mlme.c

From: Darshil Shah

Date: Wed Dec 17 2025 - 08:51:33 EST


Thanks for the clarification.

This was intended as a minor style cleanup only.
Since there is no functional impact, I agree it’s not necessary.
I’ll drop this patch.

Thanks for the review.


On Wed, Dec 17, 2025 at 7:06 PM Darshil Shah <darshilshah7070@xxxxxxxxx> wrote:
>
> Thanks for the clarification.
>
> This was intended as a minor style cleanup only.
> Since there is no functional impact, I agree it’s not necessary.
> I’ll drop this patch.
>
> Thanks for the review.
>
> On Wed, Dec 17, 2025 at 6:39 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>>
>> On Tue, Dec 16, 2025 at 02:39:01AM +0530, Darshil Shah wrote:
>> > - Removed unnecessary parentheses around if conditions
>>
>> Only one if condition was changed.
>>
>> > - Removed redundant '== true' and '== false' comparisons
>>
>> Ok,I see why you removed this at the same time, but really, it was not
>> redundant, you just changed the operator to something else.
>>
>> But why? It's not really required by anything, what is driving this
>> change?
>>
>> thanks,
>>
>> greg k-h