Re: [PATCH RFC net-next 6/6] net: phy: motorcomm: fix duplex setting error for phy leds

From: Andrew Lunn
Date: Wed Dec 17 2025 - 08:58:16 EST


On Wed, Dec 17, 2025 at 09:05:20PM +0800, Jijie Shao wrote:
>
> on 2025/12/16 15:21, Andrew Lunn wrote:
> > On Mon, Dec 15, 2025 at 08:57:05PM +0800, Jijie Shao wrote:
> > > fix duplex setting error for phy leds
> > >
> > > Fixes: 355b82c54c12 ("net: phy: motorcomm: Add support for PHY LEDs on YT8521")
> > > Signed-off-by: Jijie Shao <shaojijie@xxxxxxxxxx>
> > Please don't mix new development and fixes in one patchset. Please
> > base this patch on net, and send it on its own.
> >
> > https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
> >
> > Fixes are accepted any time, it does not matter about the merge
> > window.
> >
> > Andrew
>
> Yes, this is RFC, just for code review.
> I sent it to net when requesting a merge.

This is however a real fix. The motorcomm driver is broken. Why wait
to fix it?

Andrew