Re: [PATCH v8 20/21] printk: Deprecate the kernel.printk sysctl interface

[Geert Uytterhoeven]

Hi Joel,

On Wed, 17 Dec 2025 at 12:47, Joel Granados <joel.granados@xxxxxxxxxx> wrote:
> On Mon, Dec 15, 2025 at 05:06:40PM +0100, Petr Mladek wrote:
> > On Mon 2025-12-15 10:52:28, Joel Granados wrote:
> > > On Fri, Dec 12, 2025 at 04:51:46PM +0100, Petr Mladek wrote:
> > > > > +               pr_warn_once("printk: The kernel.printk sysctl is deprecated. Consider using kernel.console_loglevel or kernel.default_message_loglevel instead.\n");
> > > Line seems very long. cut it in two?
> >
> > OK, what about the following?
> >
> >       pr_warn_once("printk: The kernel.printk sysctl is deprecated and will be removed in 2036.\n");
> >       pr_warn_once("printk: Use kernel.console_loglevel or kernel.default_message_loglevel instead.\n");
> I meant it more as a long line in the code. Not a long line in the
> log. Like this:
>
>   pr_warn_once("printk: The kernel.printk sysctl is deprecated. Instead, use "
>                "kernel.console_loglevel or kernel.default_message_loglevel.\n");
>
> Its still long, but more manageable.

Please do not split long messages, as it makes it harder to find them
in the source tree.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds