Re: [PATCH] tty: serial: Replace deprecated PCI API

[Guenter Roeck]

On 12/17/25 06:06, Greg Kroah-Hartman wrote:
> On Thu, Dec 11, 2025 at 02:57:46PM +0100, Philipp Stanner wrote:
> > On Wed, 2025-11-26 at 09:02 -0800, Guenter Roeck wrote:
> > > On 11/26/25 01:10, Philipp Stanner wrote:
> > > > pcim_iomap_table() is deprecated. Moreover, its special usage in 8250,
> > > > causes a WARN_ON to fire (in pcim_add_mapping_to_legacy_table()).
> > > >
> > > > 8250's function serial8250_pci_setup_port() effectively maps the same
> > > > BAR multiple times and adds an offset to the start address. While
> > > > mapping and adding offsets is not a bug, it can be achieved in a far
> > > > more straightforward way by using the specialized function
> > > > pcim_iomap_range().
> > > >
> > > > pcim_iomap_range() does not add the mapping addresses to the deprecated
> > > > iomap table - that's not a problem, however, because non of the users of
> > > > serial8250_pci_setup_port() uses pcim_iomap_table().
> > > >
> > > > Replace the deprecated PCI functions with pcim_iomap_range().
> > > >
> > > > Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> > > > Link: https://lore.kernel.org/dri-devel/16cd212f-6ea0-471d-bf32-34f55d7292fe@xxxxxxxxxxxx/
> > > > Signed-off-by: Philipp Stanner <phasta@xxxxxxxxxx>
> > > > ---
> > > > @Guenther: Can you please test this? I hope it fixes your issue.
> > >
> > > Yes, it does. Thanks a lot for fixing this!
> > >
> > > Tested-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> >
> > @Greg:
> > Can you apply this?
>
> Does not apply at all to 6.19-rc1 :(

It conflicts with commit b7cefdb663382 ("serial: 8250_pcilib: Replace deprecated
PCI functions"). Unfortunately that commit does not fix the problem; I still
see it with v6.19-rc1.

Guenter