Re: [PATCH 3/3] gpio: realtek-otto: use of instead of device handlers

[Rosen Penev]

On Wed, Dec 17, 2025 at 1:30 AM Bartosz Golaszewski <brgl@xxxxxxxxxx> wrote:
>
> On Wed, Dec 17, 2025 at 7:32 AM Rosen Penev <rosenp@xxxxxxxxx> wrote:
> >
> > This is an OF only driver. No point in using generic device handlers.
> >
> > Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> > ---
> >  drivers/gpio/gpio-realtek-otto.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-realtek-otto.c b/drivers/gpio/gpio-realtek-otto.c
> > index efcddbe01308..8bad43afc586 100644
> > --- a/drivers/gpio/gpio-realtek-otto.c
> > +++ b/drivers/gpio/gpio-realtek-otto.c
> > @@ -372,10 +372,10 @@ static int realtek_gpio_probe(struct platform_device *pdev)
> >         if (!ctrl)
> >                 return -ENOMEM;
> >
> > -       dev_flags = (unsigned int)(kernel_ulong_t)device_get_match_data(dev);
> > +       dev_flags = (unsigned int)(kernel_ulong_t)of_device_get_match_data(dev);
> >
> >         ngpios = REALTEK_GPIO_MAX;
> > -       device_property_read_u32(dev, "ngpios", &ngpios);
> > +       of_property_read_u32(dev->of_node, "ngpios", &ngpios);
> >
> >         if (ngpios > REALTEK_GPIO_MAX) {
> >                 dev_err(&pdev->dev, "invalid ngpios (max. %d)\n",
> > --
> > 2.52.0
> >
>
> Yeah, no, there's almost *never* a point in using OF-specific accessors. NAK.
Argument made to me on netdev before is it's pointless overhead for an
OF only driver.
>
> Bart