Re: [PATCH RFC 01/16] dt-bindings: hwmon: Convert aspeed,ast2400-pwm-tacho to DT schema

From: Andrew Jeffery
Date: Wed Dec 17 2025 - 17:01:21 EST


On Wed, 2025-12-17 at 09:37 -0600, Rob Herring wrote:
> On Thu, Dec 11, 2025 at 2:46 AM Andrew Jeffery
> <andrew@xxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > From: "Rob Herring (Arm)" <robh@xxxxxxxxxx>
> >
> > Convert the ASpeed fan controller binding to DT schema format.
> >
> > The '#cooling-cells' value used is 1 rather than 2. '#size-cells' is 0
> > rather 1.
>
> Okay, I can't figure out why I thought '#cooling-cells' needed to be 1
> here. I don't see that anywhere in the tree. The driver for sure only
> supports 2, so anything that's not is an error in any case.

Yeah, I'd started doing some digging to understand your statement about
it needing to be 1 but hadn't got to the bottom of it.

If it can be 2 then great, I can fix up the #size-cells and resend.

Andrew