RE: [PATCH 2/2] EDAC/igen6: Make masks of {MCHBAR, TOM, TOUUD, ECC_ERROR_LOG} configurable

[Zhuo, Qiuxu]

> From: Luck, Tony <tony.luck@xxxxxxxxx>
> Sent: Thursday, December 18, 2025 2:19 AM
> To: Zhuo, Qiuxu <qiuxu.zhuo@xxxxxxxxx>
> Cc: Borislav Petkov <bp@xxxxxxxxx>; Gao, Jianfeng <jianfeng.gao@xxxxxxxxx>;
> Lai, Yi1 <yi1.lai@xxxxxxxxx>; linux-edac@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 2/2] EDAC/igen6: Make masks of {MCHBAR, TOM, TOUUD,
> ECC_ERROR_LOG} configurable
> 
> On Mon, Nov 24, 2025 at 02:54:57PM +0800, Qiuxu Zhuo wrote:
> > diff --git a/drivers/edac/igen6_edac.c b/drivers/edac/igen6_edac.c
> > index 5d887a3115f0..db4aa9f581e3 100644
> > --- a/drivers/edac/igen6_edac.c
> > +++ b/drivers/edac/igen6_edac.c
> ...
> > +/* Non-constant mask variant of FIELD_GET() */ #define
> > +field_get(mask, reg)  (((reg) & (mask)) >> (ffs(mask) - 1))
> 
> I applied to v6.19-rc1. But when building with make W=1 I get this warning:
> 
> drivers/edac/igen6_edac.c:125:9: warning: "field_get" redefined
>   125 | #define field_get(mask, reg)  (((reg) & (mask)) >> (ffs(mask) - 1))
>       |         ^~~~~~~~~

Thanks Tony for reporting this warning.

A global non-constant field_get() helper is now included in <linux/bitfield.h> from 
v6.19-rc1,  so the driver doesn't need to define it locally.

I'll remove the local field_get() definition from the driver in v2 to fix this warning.

-Qiuxu