Re: [PATCH v3 4/6] platform/surface: aggregator_registry: Add Surface Pro 11

[Jérôme de Bretagne]

Le jeu. 18 déc. 2025 à 01:07, Dmitry Baryshkov
<dmitry.baryshkov@xxxxxxxxxxxxxxxx> a écrit :
>
> On Thu, Dec 18, 2025 at 12:56:40AM +0100, Jérôme de Bretagne via B4 Relay wrote:
> > From: Dale Whinham <daleyo@xxxxxxxxx>
> >
> > This enables support for the X1-based Surface Pro 11.
> >
> > Signed-off-by: Dale Whinham <daleyo@xxxxxxxxx>
> > Signed-off-by: Jérôme de Bretagne <jerome.debretagne@xxxxxxxxx>
> > Reviewed-by: Maximilian Luz <luzmaximilian@xxxxxxxxx>
> > ---
> >  drivers/platform/surface/surface_aggregator_registry.c | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >
> > diff --git a/drivers/platform/surface/surface_aggregator_registry.c b/drivers/platform/surface/surface_aggregator_registry.c
> > index 78ac3a8fbb736384f7e50f1888a71297a892a7c3..c18d991afc8b0a0bbb26966351b75b8ea01097a4 100644
> > --- a/drivers/platform/surface/surface_aggregator_registry.c
> > +++ b/drivers/platform/surface/surface_aggregator_registry.c
> > @@ -406,6 +406,22 @@ static const struct software_node *ssam_node_group_sp9_5g[] = {
> >       NULL,
> >  };
> >
> > +/* Devices for Surface Pro 11 (ARM/QCOM) */
> > +static const struct software_node *ssam_node_group_sp11[] = {
> > +     &ssam_node_root,
> > +     &ssam_node_hub_kip,
> > +     &ssam_node_bat_ac,
> > +     &ssam_node_bat_main,
> > +     &ssam_node_tmp_sensors,
> > +     &ssam_node_hid_kip_keyboard,
> > +     &ssam_node_hid_kip_penstash,
> > +     &ssam_node_hid_kip_touchpad,
> > +     &ssam_node_hid_kip_fwupd,
> > +     &ssam_node_hid_sam_sensors,
> > +     &ssam_node_kip_tablet_switch,
> > +     NULL,
> > +};
> > +
> >  /* -- SSAM platform/meta-hub driver. ---------------------------------------- */
> >
> >  static const struct acpi_device_id ssam_platform_hub_acpi_match[] = {
> > @@ -485,6 +501,8 @@ static const struct of_device_id ssam_platform_hub_of_match[] __maybe_unused = {
> >       /* Surface Laptop 7 */
> >       { .compatible = "microsoft,romulus13", (void *)ssam_node_group_sl7 },
> >       { .compatible = "microsoft,romulus15", (void *)ssam_node_group_sl7 },
> > +     /* Surface Pro 11 */
> > +     { .compatible = "microsoft,denali", (void *)ssam_node_group_sp11 },
>
> Please keep it sorted. arcata < denali < romulus

Thank you, I will fix this in v4.


> >       { },
> >  };
> >
> >
> > --
> > 2.47.3
> >
> >
>
> --
> With best wishes
> Dmitry