Re: [PATCH net-next v1 2/3] dt-bindings: net: micrel: Add keep-preamble-before-sfd
From: Stefan Eichenberger
Date: Thu Dec 18 2025 - 03:59:51 EST
Hi Andrew,
On Wed, Dec 17, 2025 at 06:04:56PM +0100, Andrew Lunn wrote:
> > > I think the ideal implementation would be the MAC driver calling some
> > > phy API to apply the quirk, and then that gets passed on to the phy
> > > driver. Surely this isn't the first case of a MAC-PHY combination
> > > needing to go fiddle with some special setting.
> >
> > I was also hoping to find something like that, but I couldn't really
> > find it. However, I will try looking in that direction. At least we can
> > identify the broken MAC via the compatible string of the MAC driver, as
> > they use two different compatibles: 'fsl,imx8mp-fec' (fine) and
> > 'nxp,imx8mp-dwmac-eqos' (affected by the errata).
>
> Maybe see if you can use phy_register_fixup_for_id().
That sounds really promising. Thanks a lot for the tip! I'll try to
address our problem by registering a fixup.
Regards,
Stefan