Re: [PATCH v2 04/28] mm: vmscan: prepare for the refactoring the move_folios_to_lru()

[Qi Zheng]

On 12/18/25 5:04 PM, David Hildenbrand (Red Hat) wrote:
> On 12/17/25 08:27, Qi Zheng wrote:
> > From: Qi Zheng <zhengqi.arch@xxxxxxxxxxxxx>
> >
> > After refactoring the move_folios_to_lru(), its caller no longer needs to
> > hold the lruvec lock, the disabling IRQ is only for __count_vm_events()
> > and __mod_node_page_state().
> >
> > On the PREEMPT_RT kernel, the local_irq_disable() cannot be used. To
> > avoid using local_irq_disable() and reduce the critical section of
> > disabling IRQ, make all callers of move_folios_to_lru() use IRQ-safed
> > count_vm_events() and mod_node_page_state().
>
> The patch description is a bit confusing for me.
>
> I assume you mean something like
>
> "Once we refactor move_folios_to_lru(), its callers will no longer have 
> to hold the lruvec lock; disabling IRQs is then only required for 
> __count_vm_events() and __mod_node_page_state().
>
> To prepare for that, let's $YOURDETAILSHERE"

It is indeed clearer, will do in the next version.

>