Re: [PATCH v3 1/2] media: dt-bindings: Correct camss VDDA PLL supply description

[David Heidelberg]

On 18/12/2025 09:12, Krzysztof Kozlowski wrote:
> On Tue, Dec 16, 2025 at 01:24:50PM +0100, David Heidelberg wrote:
> > Usually, the supply is around 1.2 V, not 1.8 V. Rather remove mention of
> > voltage from the description.
>
> You did not remove the voltage. Anyway, both commits should be squashed.
>
> > Fixes: 849139d46d09 ("media: dt-bindings: media: camss: Fixup vdda regulator descriptions sdm845")
> > Signed-off-by: David Heidelberg <david@xxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml  | 2 +-
> >   Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml   | 2 +-
> >   Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml | 2 +-
> >   Documentation/devicetree/bindings/media/qcom,sdm670-camss.yaml   | 2 +-
> >   Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml   | 2 +-
> >   Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml   | 2 +-
> >   6 files changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> > index 019caa2b09c32..4986d18d1a2da 100644
> > --- a/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> > +++ b/Documentation/devicetree/bindings/media/qcom,sa8775p-camss.yaml
> > @@ -130,7 +130,7 @@ properties:
> >   
> >     vdda-pll-supply:
> >       description:
> > -      Phandle to 1.8V regulator supply to PHY refclk pll block.
> > +      1.2V regulator supply to CSIPHY IP blocks.
>
> "...that supply is a regulator supply" so you still decided to go that
> way. Why? I think I could not write this clearer.

Oh! Vladimir mentioned the supplies should look like in

> names like found in qcom,x1e80100-camss.yaml, qcom,qcm2290-camss.yaml 
and qcom,sm8650-camss.yaml

I blindly considered these to be "examples how it should look like" and 
used the more recent description without checking them.

I'll squash the commits in next version and rephrase all camss the 
supplies correctly, if it make sense to you.

Sorry for the inconvenience and thanks.
David

> Best regards,
> Krzysztof

--
David Heidelberg