Re: [PATCH] sparc: Use vmemmap_populate_hugepages for vmemmap_populate

[Tao pilgrim]

On Thu, Dec 18, 2025 at 8:11 PM Mike Rapoport <rppt@xxxxxxxxxx> wrote:
>
> On Thu, Dec 18, 2025 at 07:45:52PM +0800, Tao pilgrim wrote:
> > On Thu, Dec 18, 2025 at 7:14 PM Mike Rapoport <rppt@xxxxxxxxxx> wrote:
> > >
> > > On Wed, Dec 17, 2025 at 08:08:58PM +0800, chengkaitao wrote:
> > > > From: Chengkaitao <chengkaitao@xxxxxxxxxx>
> > > >
> > > > 1. Added the vmemmap_false_pmd function to accommodate architectures
> > > > that do not support basepages.
> > > > 2. In the SPARC architecture, reimplemented vmemmap_populate using
> > > > vmemmap_populate_hugepages.
> > >
> > > What problem this patch is trying to solve?
> >
> > Following the pattern established by other architectures, vmemmap_populate
> > is reimplemented using vmemmap_populate_hugepages in the SPARC architecture,
> > which fulfills the intended purpose of vmemmap_populate_hugepages.
>
> But what's wrong with the current sparc::vmemmap_populate()?

The current implementation of sparc::vmemmap_populate() is correct
and functional.

However, I believe that generalizing vmemmap_populate_hugepages()
still results in certain architectures requiring special-case handling
branches, which is contrary to our goal of a unified implementation.

Another benefit is that it allows us to eliminate the external
declarations of vmemmap_p?d_populate functions and convert
them to static functions.

> > The functional logic remains unchanged.
> >
> > > > Signed-off-by: Chengkaitao <chengkaitao@xxxxxxxxxx>
> > > > ---

-- 
Yours,
Kaitao Cheng