Re: [PATCH can] can: fix build dependency

[Marc Kleine-Budde]

On 17.12.2025 23:24:05, Vincent Mailhol wrote:
> On 17/12/2025 at 10:45, Marc Kleine-Budde wrote:
> > Arnd Bergmann's patch [1] fixed the build dependency problem introduced by
> > bugfix commit cb2dc6d2869a ("can: Kconfig: select CAN driver infrastructure
> > by default"). This ended up as commit 6abd4577bccc ("can: fix build
> > dependency"), but I broke Arnd's fix by removing a dependency that we
> > thought was superfluous.
>
> And my comment subverted you into doing so. I think half of the blame goes to me
> here.

:)

> > [1] https://lore.kernel.org/all/20251204100015.1033688-1-arnd@xxxxxxxxxx/
> >
> > Meanwhile the problem was also found by intel's kernel test robot,
> > complaining about undefined symbols:
> >
> > | ERROR: modpost: "m_can_class_unregister" [drivers/net/can/m_can/m_can_platform.ko] undefined!
> > | ERROR: modpost: "m_can_class_free_dev" [drivers/net/can/m_can/m_can_platform.ko] undefined!
> > | ERROR: modpost: "m_can_class_allocate_dev" [drivers/net/can/m_can/m_can_platform.ko] undefined!
> > | ERROR: modpost: "m_can_class_get_clocks" [drivers/net/can/m_can/m_can_platform.ko] undefined!
> > | ERROR: modpost: "m_can_class_register" [drivers/net/can/m_can/m_can_platform.ko] undefined!
> >
> > To fix this problem, add the missing dependency again.
> >
> > Cc: Vincent Mailhol <mailhol@xxxxxxxxxx>
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202512132253.vO9WFDJK-lkp@xxxxxxxxx/
> > Reported-by: Arnd Bergmann <arnd@xxxxxxxx>
> > Closes: https://lore.kernel.org/all/7427949a-ea7d-4854-9fe4-e01db7d878c7@xxxxxxxxxxxxxxxx/
> > Fixes: 6abd4577bccc ("can: fix build dependency")
> > Fixes: cb2dc6d2869a ("can: Kconfig: select CAN driver infrastructure by default")
> > Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
>
> Acked-by: Vincent Mailhol <mailhol@xxxxxxxxxx>

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Attachment: signature.asc
Description: PGP signature