Re: [PATCH] trace: make ftrace likely counters atomic

From: Steven Rostedt

Date: Tue Dec 23 2025 - 16:54:58 EST


On Tue, 23 Dec 2025 22:37:14 +0200
Khaled Saleh <khaled.saleh.req@xxxxxxxxx> wrote:

> The correct and incorrect counters in ftrace_likely_update() are
> updated without synchronization and may race on SMP systems.

Yes, it can race, but its mostly just heuristics anyway, so missed counters
are not a problem.

>
> Convert them to atomic counters to address the existing FIXME
> without changing behavior.

There's a reason why they are not atomic. You think I would put in a
"FIXME" if it was that easy?

Sorry, NAK.

-- Steve