Re: [PATCH 05/13] spi: cadence-qspi: Remove an useless operation

From: Pratyush Yadav

Date: Tue Dec 23 2025 - 09:32:17 EST


On Fri, Dec 19 2025, Miquel Raynal (Schneider Electric) wrote:

> Right above writing the register value back based on 'div' value, there
> is the following check:
>
> if (div > CQSPI_REG_CONFIG_BAUD_MASK)
> div = CQSPI_REG_CONFIG_BAUD_MASK;
>
> which means div does not need to be AND'ed against the bitfield mask.
>
> Remove this redundant operation.
>
> Signed-off-by: Miquel Raynal (Schneider Electric) <miquel.raynal@xxxxxxxxxxx>

Reviewed-by: Pratyush Yadav <pratyush@xxxxxxxxxx>

[...]

--
Regards,
Pratyush Yadav