Re: [PATCH v3] PCI: xilinx: Fix INTx IRQ domain leak in error paths
From: Manivannan Sadhasivam
Date: Tue Dec 23 2025 - 07:30:00 EST
On Fri, 19 Dec 2025 10:16:15 +0800, Haotian Zhang wrote:
> In xilinx_pcie_init_irq_domain(), if xilinx_allocate_msi_domains()
> fails after pcie->leg_domain has been successfully created via
> irq_domain_create_linear(), the function returns directly without
> cleaning up the allocated IRQ domain, resulting in a resource leak.
> In xilinx_free_msi_domains(), pcie->leg_domain is also neglected.
>
> Add irq_domain_remove() call in the error path to properly release the
> IRQ domain before returning the error. Rename xilinx_free_msi_domains()
> to xilinx_free_irq_domains() and add the release of pcie->leg_domain
> in the function.
>
> [...]
Applied, thanks!
[1/1] PCI: xilinx: Fix INTx IRQ domain leak in error paths
commit: f42b3c053b1554d66af6fe45bb1ef357464c0456
Best regards,
--
Manivannan Sadhasivam <mani@xxxxxxxxxx>