Re: [PATCH] ALSA: hda/tas2781: properly initialize speaker_id for TAS2563

[Takashi Iwai]

On Mon, 22 Dec 2025 20:47:04 +0100,
August Wikerfors wrote:
> 
> After speaker id retrieval was refactored to happen in tas2781_read_acpi,
> devices that do not use a speaker id need a negative speaker_id value
> instead of NULL, but no initialization was added to the TAS2563 code path.
> This causes the driver to attempt to load a non-existent firmware file name
> with a speaker id of 0 ("TAS2XXX38700.bin") instead of the correct file
> name without a speaker id ("TAS2XXX3870.bin"), resulting in low volume and
> these dmesg errors:
> 
>     tas2781-hda i2c-INT8866:00: Direct firmware load for TAS2XXX38700.bin failed with error -2
>     tas2781-hda i2c-INT8866:00: tasdevice_dsp_parser: load TAS2XXX38700.bin error
>     tas2781-hda i2c-INT8866:00: dspfw load TAS2XXX38700.bin error
>     [...]
>     tas2781-hda i2c-INT8866:00: tasdevice_prmg_load: Firmware is NULL
> 
> Fix this by setting speaker_id to -1 as is done for other models.
> 
> Fixes: 945865a0ddf3 ("ALSA: hda/tas2781: fix speaker id retrieval for multiple probes")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: August Wikerfors <git@xxxxxxxxxxxxxxxxxx>

Applied now.  Thanks.


Takashi