Re: [PATCH v3 1/1] RDMA/rxe: Avoid -Wflex-array-member-not-at-end warnings

[Gustavo A. R. Silva]

On 12/23/25 15:46, Zhu Yanjun wrote:
> 在 2025/12/22 21:54, Gustavo A. R. Silva 写道:
> > On 12/23/25 14:44, Zhu Yanjun wrote:
> > > 在 2025/12/22 21:34, Gustavo A. R. Silva 写道:
> > > > > > > > > V2->V3: Replace struct ib_sge with struct rxe_sge
> > > > > > > >
> > > > > > > > What are you doing?
> > > > > > >
> > > > > > > Because struct rxe_sge differs from struct ib_sge, I aligned it to use the same structure.
> > > > > >
> > > > > > Listen, this is not how things are done upstream. Read what I previously commented:
> > > > > >
> > > > > > > > You're making a mess of this whole thing. Please, don't make changes
> > > > > > > > to my patches on your own.
> > > > > >
> > > > > > and please, learn how to properly submit patch series.
> > > > > >
> > > > > > Lastly, do the changes that you want/need to implement in your code, and don't
> > > > > > submit my patch as part of those changes again.
> > > > >
> > > > > You can correct this patch by yourself.
> > > >
> > > > https://lore.kernel.org/linux-hardening/ad8987ae-b7fe-47af-a1d2-5055749011c0@xxxxxxxxxxxxxx/
> > >
> > > You need to do some changes in your commit.
> >
> > This is what you haven't understood yet. If the original code is wrong (e.g. is
> > currently using struct ib_sge instead of struct rxe_sge or the other way around),
> > then _that_ code should be fixed _first_, regardless of any other patch that might
> > be applied on top of it.
>
> Your commit should align the 2 structs.

No. It should not. To understand why, read my previous responses.

-Gustavo