Re: [PATCH v5 1/3] dma-mapping: benchmark: modify the framework to adapt to more map modes

[Qinxin Xia]

On 2025/12/23 11:13:32, Qinxin Xia <xiaqinxin@xxxxxxxxxx> wrote:
> On 2025/12/23 10:58:28, Barry Song <21cnbao@xxxxxxxxx> wrote:
> > I’ve reviewed it many times. You are:
> >
> > +               if (!mb_ops->prepare_data)
> > +                       mb_ops->prepare_data(mparam);
> >
> > not
> >                 if (mb_ops->prepare_data)
> >                         mb_ops->prepare_data(mparam);
> > Am I crazy?
> >
> > Thanks
> > Barry
> Yes, I've found the mistake...
>
> So in my just reply, I mentioned the correct modification of the
> "if (mb_ops->prepare_data)" and suggested that if you want to test it
> before the next version, you can modify the patch in this way.
>
> Sorry for the confusion

if (!mb_ops->prepare_data) is a bug. Thank you for catching it.
I've tested the correct version and it works.

--
Thanks,
Qinxin