Re: [PATCH v5 1/3] dma-mapping: benchmark: modify the framework to adapt to more map modes

From: Barry Song

Date: Mon Dec 22 2025 - 21:58:41 EST


> >> + if (!mb_ops->prepare_data)
> >> + mb_ops->prepare_data(mparam);
> >
> > Did you actually test it? and why don't you need prepare_data() sometimes?
> >
> > Thanks
> > Barry
> 'if (mb_ops->prepare_data)' is correct.
> If you want to do some tests before I release the next version, you can
> modify it in this way. I have tested it and it is work.

I’ve reviewed it many times. You are:

+ if (!mb_ops->prepare_data)
+ mb_ops->prepare_data(mparam);

not
if (mb_ops->prepare_data)
mb_ops->prepare_data(mparam);
Am I crazy?

Thanks
Barry