Re: [PATCH] sparc/vdso: add missing prototypes

[Randy Dunlap]

On 12/21/25 11:36 PM, Thomas Weißschuh wrote:
> Hi Randy,
> 
> On Mon, Dec 08, 2025 at 09:03:32PM -0800, Randy Dunlap wrote:
>> On sparc64, when CONFIG_WERROR=y, there are a few missing-prototype
>> build errors. Fix them.
>>
>> Add the 4 missing prototypes to <asm/vdso.h> and include that header
>> file in vclock_gettime.c.
>>
>> Fixes these build errors:
>> In file included from ../arch/sparc/vdso/vdso32/vclock_gettime.c:22:
>> ../arch/sparc/vdso/vdso32/../vclock_gettime.c:274:1: error: no previous
>>  prototype for '__vdso_clock_gettime' [-Werror=missing-prototypes]
>> ../arch/sparc/vdso/vdso32/../vclock_gettime.c:302:1: error: no previous
>>  prototype for '__vdso_clock_gettime_stick' [-Werror=missing-prototypes]
>> ../arch/sparc/vdso/vdso32/../vclock_gettime.c:327:1: error: no previous
>>  prototype for '__vdso_gettimeofday' [-Werror=missing-prototypes]
>> ../arch/sparc/vdso/vdso32/../vclock_gettime.c:363:1: error: no previous
>>  prototype for '__vdso_gettimeofday_stick' [-Werror=missing-prototypes]
> 
> This issue would also be fixed by my patch series adopting the generic
> vDSO library on SPARC [0].
> Picking up your patch would introduce conflicts.
> 
> [0] https://lore.kernel.org/lkml/20251106-vdso-sparc64-generic-2-v5-0-97ff2b6542f7@xxxxxxxxxxxxx/

OK, thanks for the info.
Patch dropped.

-- 
~Randy