Re: [PATCH] lib/tests: convert test_min_heap module to KUnit

[Ryota Sakamoto]

Hi Kuan-Wei,

On Mon, Dec 22, 2025 at 12:50 PM Kuan-Wei Chiu <visitorckw@xxxxxxxxx> wrote:
> While the change itself looks good, the commit message focuses heavily
> on *what* the patch does. I would prefer to see an explanation of *why*
> this patch is needed. Specifically, what are the benefits of converting
> to kunit compared to the original implementation?

You are right. In the original commit message, I focused on what we
did, not why we did.
The reasons for converting to KUnit are:
1. Standardization:
    Switching from ad-hoc printk-based reporting to the standard KTAP
format makes
    it easier for CI systems to parse and report test results
2. Better Diagnostics:
    Using KUNIT_EXPECT_* macros automatically provides detailed
diagnostics on failure.
3. Tooling Integration:
    It allows the test to be managed and executed using standard KUnit tools.

Hi Andrew,

Since this patch is already in your mm-nonmm-unstable tree, would you
prefer me to send
a v2 patch with the updated commit message, or could you kindly fold
these explanations
into the commit log?

Best regards,
Ryota Sakamoto