Re: [PATCH net v3] net: nfc: nci: Fix parameter validation for packet data

[Vadim Fedorenko]

On 22/12/2025 14:31, Michael Thalmeier wrote:
> @@ -668,6 +679,11 @@ static int nci_rf_intf_activated_ntf_packet(struct nci_dev *ndev,
>   		}
>   	}
>   
> +	if (skb->len < (data - skb->data) + sizeof(ntf.data_exch_rf_tech_and_mode) +
> +				sizeof(ntf.data_exch_tx_bit_rate) + sizeof (ntf.data_exch_rx_bit_rate) +

extra space between sizeof and the bracket

> +				sizeof(ntf.activation_params_len))
> +		return -EINVAL;
> +
>   	ntf.data_exch_rf_tech_and_mode = *data++;
>   	ntf.data_exch_tx_bit_rate = *data++;
>   	ntf.data_exch_rx_bit_rate = *data++;