Re: [PATCH 10/16] KVM: emulate: Handle EGPR index and REX2-incompatible opcodes

[Paolo Bonzini]

On 12/21/25 05:07, Chang S. Bae wrote:
> @@ -175,6 +175,7 @@
>   #define TwoMemOp    ((u64)1 << 55)  /* Instruction has two memory operand */
>   #define IsBranch    ((u64)1 << 56)  /* Instruction is considered a branch. */
>   #define ShadowStack ((u64)1 << 57)  /* Instruction affects Shadow Stacks. */
> +#define NoRex       ((u64)1 << 58)  /* Instruction has no use of REX prefix */

While you have explained in the commit message that these are 
instructions that ignore REX, the flag is only used for REX2 and you're 
defining it based on the REX2 parts of the manual.

So I would call this NoRex2 ("Instruction not present in REX2 maps").

Paolo