Re: [PATCH] rust_binder: replace `kernel::c_str!` with C-Strings

From: Daniel Almeida

Date: Mon Dec 22 2025 - 09:26:45 EST




> On 22 Dec 2025, at 09:22, Tamir Duberstein <tamird@xxxxxxxxxx> wrote:
>
> From: Tamir Duberstein <tamird@xxxxxxxxx>
>
> C-String literals were added in Rust 1.77. Replace instances of
> `kernel::c_str!` with C-String literals where possible.
>
> Signed-off-by: Tamir Duberstein <tamird@xxxxxxxxx>
> ---
> drivers/android/binder/rust_binder_main.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/android/binder/rust_binder_main.rs b/drivers/android/binder/rust_binder_main.rs
> index c79a9e742240..519bc2fb310d 100644
> --- a/drivers/android/binder/rust_binder_main.rs
> +++ b/drivers/android/binder/rust_binder_main.rs
> @@ -288,7 +288,7 @@ fn init(_module: &'static kernel::ThisModule) -> Result<Self> {
>
> pr_warn!("Loaded Rust Binder.");
>
> - BINDER_SHRINKER.register(kernel::c_str!("android-binder"))?;
> + BINDER_SHRINKER.register(c"android-binder")?;
>
> // SAFETY: The module is being loaded, so we can initialize binderfs.
> unsafe { kernel::error::to_result(binderfs::init_rust_binderfs())? };
>
> ---
> base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
> change-id: 20251222-cstr-staging-e96cbee7d73e
>
> Best regards,
> --
> Tamir Duberstein <tamird@xxxxxxxxx>
>
>

Reviewed-by: Daniel Almeida <daniel.almeida@xxxxxxxxxxxxx>