Re: [PATCH v3 1/2] dt-bindings: leds: leds-qcom-lpg: Add support for PMH0101 PWM

[Jishnu Prakash]

Hi Krzysztof,

On 12/17/2025 1:45 PM, Krzysztof Kozlowski wrote:
> On Mon, Dec 15, 2025 at 04:41:04PM +0530, Jishnu Prakash wrote:
>> Add support for PMH0101 PWM modules which are compatible with the PM8350c
>> PWM modules.
>>
>> Signed-off-by: Jingyi Wang <jingyi.wang@xxxxxxxxxxxxxxxx>
>> Signed-off-by: Jishnu Prakash <jishnu.prakash@xxxxxxxxxxxxxxxx>
>> ---
>>  Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 1 +
>>  1 file changed, 1 insertion(+)
> 
> So how many nvmem entries it has? You need to define it in schema.
> 

PMH0101 PWM has 2 nvmem entries, the same as PM8350C. But I see that
PM8550 PWM was earlier added under the "if:then" condition for the number
of nvmem entries and you made this change which removed that line:

https://lore.kernel.org/all/20240226073713.19045-1-krzysztof.kozlowski@xxxxxxxxxx/

    dt-bindings: leds: qcom-lpg: Drop redundant qcom,pm8550-pwm in if:then:

    "qcom,pm8550-pwm" is compatible with "qcom,pm8350c-pwm" (latter used as
    fallback), thus it is enough for the "if:then:" clause to check for the
    presence of the fallback "qcom,pm8350c-pwm".

PMH0101 PWM would be the same as it also has PM8350C PWM as fallback.
Do you prefer that I add it or not?

Thanks,
Jishnu


> Best regards,
> Krzysztof
>