Re: [PATCH v10 5/6] cadence: cdns-mhdp8546*: Change drm_connector from structure to pointer

[Tomi Valkeinen]

Hi,

On 09/12/2025 14:03, Harikrishna Shenoy wrote:
> From: Jayesh Choudhary <j-choudhary@xxxxxx>
> 
> Now that we have dropped the legacy code which became redundant with
> introduction of DRM_BRIDGE_ATTACH_NO_CONNECTOR
> usecase in driver,we can cleanly switch to drm_connector pointer
> instead of structure.
> 
> Rename the connector_ptr member variable to connector for clarity and
> consistency. The driver was using both connector and connector_ptr members,
> but connector_ptr was the only one actually used throughout the code.
> This change removes the unused connector struct member and renames
> connector_ptr to connector for better readability.
> 
> This is purely a code cleanup change with no functional impact. All
> references to connector_ptr are updated to use the renamed connector
> variable throughout the driver.
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> Signed-off-by: Jayesh Choudhary <j-choudhary@xxxxxx>
> Signed-off-by: Harikrishna Shenoy <h-shenoy@xxxxxx>
> ---
>  .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.c    | 14 +++++++-------
>  .../gpu/drm/bridge/cadence/cdns-mhdp8546-core.h    |  3 +--
>  .../gpu/drm/bridge/cadence/cdns-mhdp8546-hdcp.c    | 12 ++++++------
>  3 files changed, 14 insertions(+), 15 deletions(-)

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>

 Tomi