Re: [PATCH RFC 3/6] drm/msm: mdss: Add Milos support

From: Dmitry Baryshkov

Date: Mon Dec 22 2025 - 04:12:55 EST


On 22/12/2025 11:09, Konrad Dybcio wrote:
On 12/20/25 5:52 PM, Dmitry Baryshkov wrote:
On Fri, Dec 19, 2025 at 05:41:09PM +0100, Luca Weiss wrote:
Add support for MDSS on Milos.

Signed-off-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx>
---
drivers/gpu/drm/msm/msm_mdss.c | 5 +++++
1 file changed, 5 insertions(+)


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>

Though 14000 seems lower than the value for all other platforms.

IIUC it's essentially "nonzero" or "first-level-above-just-nonzero"

The downstream DT also defines a 140_000 and a 310_000 point.. though
the middle one is never(?) used and the latter one is only used during
UEFI handoff and upon the first commit after (runtime) resume

If I remember correctly, those are also used for programming the LUTs or other big tables into the hardware.


Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad


--
With best wishes
Dmitry