Re: [PATCH v2 06/11] dt-bindings: display: panel: Describe Samsung SOFEF03-M DDIC

[Krzysztof Kozlowski]

On Mon, Dec 22, 2025 at 12:32:12AM +0100, Marijn Suijten wrote:
> Document the Samsung SOFEF03-M Display-Driver-IC and 1080x2520@120Hz DSI
> command-mode panels found in the Sony Xperia 5 II and Sony Xperia 5 III.
> It requires Display Stream Compression 1.1 which allows the panels to be
> driven at 120Hz, even though a 60Hz mode is available too.
> 
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> Signed-off-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>

Your patchset has multiple white space warnings. Apply and see...

> ---
>  .../bindings/display/panel/samsung,sofef03-m.yaml  | 79 ++++++++++++++++++++++
>  MAINTAINERS                                        |  5 ++
>  2 files changed, 84 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/samsung,sofef03-m.yaml b/Documentation/devicetree/bindings/display/panel/samsung,sofef03-m.yaml
> new file mode 100644
> index 000000000000..5712eca2773d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/samsung,sofef03-m.yaml
> @@ -0,0 +1,79 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/samsung,sofef03-m.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Samsung SOFEF03-M DDI for 1080x2520@120Hz 6.1" OLED DSI panels
> +
> +maintainers:
> +  - Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
> +
> +description: |
> +  Samsung SOFEF03-M Display-Driver-IC found in the Sony Xperia 5 II (edo pdx206, amb609vp01
> +  panel) and
> +  Sony Xperia 5 III (sagami pdx214, amb609vp04
> +  panel) smartphones.  It is always programmed with Display Stream Compression 1.1 enabled.

Please wrap according to Linux coding style.

> +
> +  The assembly features a Samsung touchscreen compatible with
> +  samsung,s6sy761.
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - samsung,sofef03-m-amb609vp01
> +      - samsung,sofef03-m-amb609vp04
> +
> +  port: true
> +
> +  reg:
> +    maxItems: 1
> +    description: DSI virtual channel
> +
> +  reset-gpios: true
> +
> +  vci-supply:
> +    description: DriverIC Operation supply (3.0V)
> +
> +  vddio-supply:
> +    description: I/O voltage supply (1.8V)
> +
> +required:
> +  - compatible
> +  - port
> +  - reg
> +  - reset-gpios
> +  - vci-supply
> +  - vddio-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    dsi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        panel@0 {
> +            compatible = "samsung,sofef03-m-amb609vp01";
> +            reg = <0>;
> +
> +            reset-gpios = <&tlmm 75 GPIO_ACTIVE_LOW>;
> +
> +            vci-supply = <&vreg_l11c_3p0>;
> +            vddio-supply = <&vreg_l14a_1p8>;
> +
> +            port {

Not tested :/


Best regards,
Krzysztof