Re: [PATCH v3 3/4] arm64: dts: qcom: Introduce Glymur base dtsi

[Bjorn Andersson]

On Sun, Dec 21, 2025 at 05:17:34PM +0200, Abel Vesa wrote:
> On 25-12-19 20:16:56, Pankaj Patil wrote:
> > Introduce the base device tree support for Glymur – Qualcomm's
> > next-generation compute SoC. The new glymur.dtsi describes the core SoC
> > components, including:
> > 
> > - CPUs and CPU topology
> > - Interrupt controller and TLMM
> > - GCC,DISPCC and RPMHCC clock controllers
> > - Reserved memory and interconnects
> > - SMMU and firmware SCM
> > - Watchdog, RPMHPD, APPS RSC and SRAM
> > - PSCI and PMU nodes
> > - QUPv3 serial engines
> > - CPU power domains and idle states, plus SCMI/ SRAM pieces for CPU DVFS
> > - PDP0 mailbox, IPCC and AOSS
> > - Display clock controller
> > - SPMI PMIC arbiter with SPMI0/1/2 buses
> > - SMP2P nodes
> > - TSENS and thermal zones (8 instances, 92 sensors)
> > 
> > Add dtsi files for PMH0101, PMK8850, PMCX0102, SMB2370, PMH0104,
> > PMH0110 along with temp-alarm and GPIO nodes needed on Glymur
> > 
> > Add glmur-pmics.dtsi file for all the pmics enabled
> > 
> > Enabled PCIe controllers and associated PHY to support boot to
> > shell with nvme storage,
> > List of PCIe instances enabled:
> > 
> > - PCIe3b
> > - PCIe4
> > - PCIe5
> > - PCIe6
> > 
> > Co-developed-by: Jyothi Kumar Seerapu <jyothi.seerapu@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Jyothi Kumar Seerapu <jyothi.seerapu@xxxxxxxxxxxxxxxx>
> > Co-developed-by: Maulik Shah <maulik.shah@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Maulik Shah <maulik.shah@xxxxxxxxxxxxxxxx>
> > Co-developed-by: Sibi Sankar <sibi.sankar@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Sibi Sankar <sibi.sankar@xxxxxxxxxxxxxxxx>
> > Co-developed-by: Taniya Das <taniya.das@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Taniya Das <taniya.das@xxxxxxxxxxxxxxxx>
> > Co-developed-by: Kamal Wadhwa <kamal.wadhwa@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Kamal Wadhwa <kamal.wadhwa@xxxxxxxxxxxxxxxx>
> > Co-developed-by: Prudhvi Yarlagadda <quic_pyarlaga@xxxxxxxxxxx>
> > Signed-off-by: Prudhvi Yarlagadda <quic_pyarlaga@xxxxxxxxxxx>
> > Co-developed-by: Qiang Yu <qiang.yu@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Qiang Yu <qiang.yu@xxxxxxxxxxxxxxxx>
> > Co-developed-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> > Co-developed-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@xxxxxxxxxxxxxxxx>
> > Co-developed-by: Jishnu Prakash <jishnu.prakash@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Jishnu Prakash <jishnu.prakash@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Pankaj Patil <pankaj.patil@xxxxxxxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/glymur-pmics.dtsi   |   11 +
> 
> Separate patch for each file, please.
> 

Why? We just told folks that we want the introduction of a new platform
consolidated into 2-3 patches.
And this would give us 6 small patches each one adding a trivial (and
presumably incomplete) pmic files.

What I don't know though is why we have pmh0104-glymur.dtsi and
pmh0110-glymur.dtsi, why are these "-glymur" ones? And why do we have
glymur-pmics.dtsi? The times we've done <soc>-pmic.dtsi, we've put all
the pmics in that one file, not just 6 includes...

Regards,
Bjorn

> Abel