RE: [PATCH net] net: enetc: do not print error log if addr is 0

[Wei Fang]

> On Fri, Dec 19, 2025 at 04:29:22PM +0800, Wei Fang wrote:
> > A value of 0 for addr indicates that the IEB_LBCR register does not
> > need to be configured, as its default value is 0. However, the driver
> > will print an error log if addr is 0, so this issue needs to be fixed.
> >
> > Fixes: 50bfd9c06f0f ("net: enetc: set external PHY address in IERB for i.MX94
> ENETC")
> > Signed-off-by: Wei Fang <wei.fang@xxxxxxx>
> > ---
> >  drivers/net/ethernet/freescale/enetc/netc_blk_ctrl.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/freescale/enetc/netc_blk_ctrl.c
> b/drivers/net/ethernet/freescale/enetc/netc_blk_ctrl.c
> > index 443983fdecd9..b2d7e0573d32 100644
> > --- a/drivers/net/ethernet/freescale/enetc/netc_blk_ctrl.c
> > +++ b/drivers/net/ethernet/freescale/enetc/netc_blk_ctrl.c
> > @@ -578,7 +578,9 @@ static int imx94_enetc_mdio_phyaddr_config(struct
> netc_blk_ctrl *priv,
> >
> >  	addr = netc_get_phy_addr(np);
> >  	if (addr <= 0) {
> > -		dev_err(dev, "Failed to get PHY address\n");
> > +		if (addr)
> > +			dev_err(dev, "Failed to get PHY address\n");
> > +
> >  		return addr;
> >  	}
> 
> Can we please handle this the same way as the other netc_get_phy_addr()
> call path (from imx95_enetc_mdio_phyaddr_config())? Separate tests for
> "if (addr < 0)" and a later "if (!addr)".
> 

Okay, thanks.