Re: [PATCH 1/1] serial: core: Fix serial device initialization
From: Greg Kroah-Hartman
Date: Sun Dec 21 2025 - 04:21:04 EST
On Sun, Dec 21, 2025 at 10:59:52AM +0200, Cosmin Tanislav wrote:
>
>
> On 12/21/25 10:40 AM, Greg Kroah-Hartman wrote:
> > On Fri, Dec 19, 2025 at 04:28:12PM +0100, Alexander Stein wrote:
> > > During restoring sysfs fwnode information the information of_node_reused
> > > was dropped. This was previously set by device_set_of_node_from_dev().
> > > Add it back manually
> > >
> > > Fixes: 24ec03cc5512 ("serial: core: Restore sysfs fwnode information")
> > > Suggested-by: Cosmin Tanislav <demonsingur@xxxxxxxxx>
> > > Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> > > ---
> > > drivers/tty/serial/serial_base_bus.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/tty/serial/serial_base_bus.c b/drivers/tty/serial/serial_base_bus.c
> > > index 8e891984cdc0d..1e1ad28d83fcf 100644
> > > --- a/drivers/tty/serial/serial_base_bus.c
> > > +++ b/drivers/tty/serial/serial_base_bus.c
> > > @@ -74,6 +74,7 @@ static int serial_base_device_init(struct uart_port *port,
> > > dev->parent = parent_dev;
> > > dev->bus = &serial_base_bus_type;
> > > dev->release = release;
> > > + dev->of_node_reused = true;
> > > device_set_node(dev, fwnode_handle_get(dev_fwnode(parent_dev)));
> > > --
> > > 2.43.0
> > >
> > >
> >
> > Can I get some confirmation from people that this resolves the issue, or
> > should I just revert the original problem commit instead and wait for a
> > tested new version?
> >
>
> Hi Greg. I confirmed that this fixes the issue before I suggested the
> fix. :D
Great, can you respond with a tested-by?