Re: clocksource: Reduce watchdog readout delay limit to prevent false positives

From: Paul E. McKenney

Date: Sat Dec 20 2025 - 11:39:31 EST


On Sat, Dec 20, 2025 at 09:37:40AM +0100, Thomas Gleixner wrote:
> On Fri, Dec 19 2025 at 16:18, Paul E. McKenney wrote:
> > On Fri, Dec 19, 2025 at 11:13:05AM +0100, Thomas Gleixner wrote:
> >> > My concern is that the patch below would force needless cs_watchdog_read()
> >> > retries.
> >>
> >> That's not the end of the world and way better than degrading the
> >> watchdog further.
> >
> > But what you proposed is just a further tweak of the heuristics you so
> > energetically decry above.
>
> I fully agree that it is a bandaid fix, but it makes the machinery
> consistent and correct. It prevents false positives, which are
> inevitable in the current design. No?

It might also be necessary to compensate by tweaking up the number of
retries by adjusting clocksource_get_max_watchdog_retry().

Thanx, Paul