Re: [PATCH v6 1/2] dt-bindings: media: i2c: Add os05b10 sensor

From: Himanshu Bhavani

Date: Sat Dec 20 2025 - 03:59:05 EST


>On 20/12/2025 07:37, Himanshu Bhavani wrote:
>> Hi Krzysztof,
>>
>>> On 19/12/2025 09:45, Himanshu Bhavani wrote:
>>>> From: Elgin Perumbilly <elgin.perumbilly@xxxxxxxxxxxxxxxxx>
>>>>
>>>> Add bindings for Omnivision OS05B10 sensor.
>>>>
>>>> Add MAINTAINERS entry for Omnivision OS05B10 binding documentation
>>>>
>>>> Signed-off-by: Elgin Perumbilly <elgin.perumbilly@xxxxxxxxxxxxxxxxx>
>>>> Signed-off-by: Himanshu Bhavani <himanshu.bhavani@xxxxxxxxxxxxxxxxx>
>>>> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx>
>>>> ---
>>>
>>>
>>> Nothing improved and you did not bother to respond to my comment.
>>
>>
>> In v5, you pointed out that the driver and bindings were mismatched with
>> respect to the reset GPIO.
>>
>> Based on that feedback, I corrected the driver by making the reset GPIO
>> optional. I also reviewed a previous patch series discussion, as suggested
>> here:
>> https://lore.kernel.org/linux-media/20250710210532.GE22436@xxxxxxxxxxxxxxxxxxxxxxxxxx/
>>
>> In that thread, Laurent suggested that GPIOs should be made optional in the
>> driver, which is what I followed in this version.
>>
>> If I have still missed something or misunderstood the feedback, please let me
>> know and I will address it.
>
>I expected reply or change in the binding. None was there, so that's why
>you got questions.

No no, definitely not ignoring your comment, you’re the boss here :)

Thanks for the review

Best Regards,
Himanshu