[PATCH next] ASoC: rt1320: Fix retry checking in rt1320_rae_load()
From: Dan Carpenter
Date: Sat Dec 20 2025 - 03:45:45 EST
This loop iterates 200 times and then gives up. The problem is that
currently the loop exits with "retry" set to -1 on the failure path but
the check for failure expects it to be 0. Change from a post-op to a
pre-op so that it exits with "retry" set to 0.
Fixes: 22937af75abb ("ASoC: rt1320: support RAE parameters loading")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---
Technically now the loop only tries 199 times after my change, however
I am okay with that.
sound/soc/codecs/rt1320-sdw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/rt1320-sdw.c b/sound/soc/codecs/rt1320-sdw.c
index 9447e742c672..c0acb6ac462d 100644
--- a/sound/soc/codecs/rt1320-sdw.c
+++ b/sound/soc/codecs/rt1320-sdw.c
@@ -1480,7 +1480,7 @@ static int rt1320_rae_load(struct rt1320_sdw_priv *rt1320)
/* RAE stop & CRC disable */
regmap_update_bits(rt1320->regmap, 0xe803, 0xbc, 0x00);
- while (retry--) {
+ while (--retry) {
regmap_read(rt1320->regmap, 0xe83f, &value);
if (value & 0x40)
break;
--
2.51.0