Re: [PATCH 07/14] iio: pressure: mprls0025pa: make ops->write function consistent

From: Marcelo Schmitt

Date: Fri Dec 19 2025 - 23:47:51 EST


On 12/18, Petre Rodan wrote:
> Make the i2c bus write operation more consistent with the rest of the
> driver.
That's not the most appealing reason for updating driver code. Is the update
meaningful for a different purpose? Consider squashing that with another patch
that makes better use of the updated function.

> Also move defines only used by core out of the common header file.
Do the define thing in a separate patch.
Commits/patches should be semantically concise (in other words, do one thing on each one).
Usually, the word 'also' in a commit description is a strong indicator that the
second thing being done should be on a patch of it's own.

>
> Signed-off-by: Petre Rodan <petre.rodan@xxxxxxxxxxxxxxx>
> ---
> drivers/iio/pressure/mprls0025pa.c | 5 +++++
> drivers/iio/pressure/mprls0025pa.h | 4 ----
> drivers/iio/pressure/mprls0025pa_i2c.c | 9 ++++++---
> 3 files changed, 11 insertions(+), 7 deletions(-)