Re: [PATCH 2/2] mux: adg1736: add driver support
From: Krzysztof Kozlowski
Date: Fri Dec 19 2025 - 12:57:46 EST
On 19/12/2025 15:35, Antoniu Miclaus wrote:
> + ret = devm_mux_chip_register(dev, mux_chip);
> + if (ret < 0)
> + return ret;
> +
> + dev_info(dev, "ADG1736 %u dual SPDT mux controllers registered\n",
> + mux_chip->controllers);
This does not look like useful printk message. Drivers should be silent
on success:
https://elixir.bootlin.com/linux/v6.15-rc7/source/Documentation/process/coding-style.rst#L913
https://elixir.bootlin.com/linux/v6.15-rc7/source/Documentation/process/debugging/driver_development_debugging_guide.rst#L79
Best regards,
Krzysztof