Re: [PATCH v3] phy: fsl-imx8mq-usb: Clear the PCS_TX_SWING_FULL field before using it

From: Fabio Estevam

Date: Fri Dec 19 2025 - 11:12:36 EST


On Fri, Dec 19, 2025 at 1:09 PM Stefano Radaelli
<stefano.radaelli21@xxxxxxxxx> wrote:
>
> Clear the PCS_TX_SWING_FULL field mask before setting the new value
> in PHY_CTRL5 register. Without clearing the mask first, the OR operation
> could leave previously set bits, resulting in incorrect register
> configuration.
>
> Fixes: 63c85ad0cd81 ("phy: fsl-imx8mp-usb: add support for phy tuning")
> Suggested-by: Leonid Segal <leonids@xxxxxxxxxxxxx>
> Acked-by: Pierluigi Passaro <pierluigi.p@xxxxxxxxxxxxx>
> Signed-off-by: Stefano Radaelli <stefano.r@xxxxxxxxxxxxx>
> Reviewed-by: Xu Yang <xu.yang_2@xxxxxxx>
> Reviewed-by: Frank Li <Frank.Li@xxxxxxx>

Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>