[PATCH 4/6] crypto: skcipher - Use unregister_skciphers in register_skciphers
From: Thorsten Blum
Date: Fri Dec 19 2025 - 09:51:47 EST
Replace the for loop with a call to crypto_unregister_skciphers().
Return 'ret' immediately and remove the goto statement to simplify the
error handling code. No functional changes.
Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
---
crypto/skcipher.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/crypto/skcipher.c b/crypto/skcipher.c
index 14a820cb06c7..09f1ba82f99a 100644
--- a/crypto/skcipher.c
+++ b/crypto/skcipher.c
@@ -741,17 +741,13 @@ int crypto_register_skciphers(struct skcipher_alg *algs, int count)
for (i = 0; i < count; i++) {
ret = crypto_register_skcipher(&algs[i]);
- if (ret)
- goto err;
+ if (ret) {
+ crypto_unregister_skciphers(algs, i);
+ return ret;
+ }
}
return 0;
-
-err:
- for (--i; i >= 0; --i)
- crypto_unregister_skcipher(&algs[i]);
-
- return ret;
}
EXPORT_SYMBOL_GPL(crypto_register_skciphers);
--
Thorsten Blum <thorsten.blum@xxxxxxxxx>
GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4