Re: [PATCH v4] mm, hugetlb: implement movable_gigantic_pages sysctl

[Gregory Price]

On Thu, Dec 18, 2025 at 04:55:38PM -0800, Andrew Morton wrote:
> On Thu, 18 Dec 2025 10:12:11 -0500 Gregory Price <gourry@xxxxxxxxxx> wrote:
> 
> > This reintroduces a concept removed by:
> > commit d6cb41cc44c6 ("mm, hugetlb: remove hugepages_treat_as_movable sysctl")
> > 
> > This sysctl provides flexibility between ZONE_MOVABLE use cases:
> > 1) onlining memory in ZONE_MOVABLE to maintain hotplug compatibility
> > 2) onlining memory in ZONE_MOVABLE to make hugepage allocate reliable
> 
> My x86_64 allmodconfig blew up.
> 
> > ...
> >
> > --- a/mm/hugetlb.c
> > +++ b/mm/hugetlb.c
> > @@ -49,7 +49,6 @@
> >  #include "internal.h"
> >  #include "hugetlb_vmemmap.h"
> >  #include "hugetlb_cma.h"
> > -#include "hugetlb_internal.h"
> >  #include <linux/page-isolation.h>
> 
> What's that doing there?  I put it back.  Helped!
> 

erk, this must have been carried over from a forward port, when all
these things moved into hugetlb_sysfs.c - very sorry, I will be more
careful.

> But the build still failed because the patch refers to
> 
> 	extern int movable_gigantic_pages __read_mostly;
> 
> but forgot to define it.  v5, please ;)
> 
> 

doh, well that's just embarassing

Will sus this out and send v5, sorry for the time sink

~Gregory