Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport

[Konrad Dybcio]

On 12/19/25 1:59 PM, Vishnu Saini wrote:
> On Fri, Dec 19, 2025 at 01:10:19PM +0100, Konrad Dybcio wrote:
>> On 12/19/25 12:20 PM, Vishnu Saini wrote:
>>> On Thu, Nov 20, 2025 at 01:11:00PM +0100, Konrad Dybcio wrote:
>>>> On 11/20/25 11:58 AM, Vishnu Saini wrote:
>>>>> Monaco-evk has LT8713sx which act as DP to 3 DP output
>>>>> converter. Edp PHY from monaco soc is connected to lt8713sx
>>>>> as input and output of lt8713sx is connected to 3 mini DP ports.
>>>>> Two of these ports are available in mainboard and one port
>>>>> is available on Mezz board. lt8713sx is connected to soc over
>>>>> i2c0 and with reset gpio connected to pin6 or ioexpander5.
>>>>>
>>>>> Enable the edp nodes from monaco and enable lontium lt8713sx
>>>>> bridge node.
>>>>>
>>>>> Co-developed-by: Prahlad Valluru <vvalluru@xxxxxxxxxxxxxxxx>
>>>>> Signed-off-by: Prahlad Valluru <vvalluru@xxxxxxxxxxxxxxxx>
>>>>> Signed-off-by: Vishnu Saini <vishnu.saini@xxxxxxxxxxxxxxxx>
>>>>> ---
>>
>> [...]
>>
>>>>> +	qup_i2c0_default: qup-i2c0-state {
>>>>> +		pins = "gpio17", "gpio18";
>>>>> +		function = "qup0_se0";
>>>>> +		drive-strength = <2>;
>>>>> +		bias-pull-up;
>>>>
>>>> Similarly, you can move these settings to monaco.dtsi and keep them as
>>>> defaults since 99.99% of I2C users will share them
>>> Is it ok if i update this in a different series, similar other nodes like qup_i2c1_default
>>> added in monaco-evk.dts?
>>
>> No, I don't want you to introduce something "wrong" only because you
>> don't want to run git commit --amend
>>
>> I see you've now sent a v2 just 7 minutes after asking this question.
>> Should I interpret that as you expecting me to drop everything and rush
>> to respond to your queries immediately, or do you not care about my
>> feedback anyway?
> Apologies, for quickly raising the new patch, i thought of correcting this
> in next V3 patch if you ask for.
> I am new contributor to the upstream community, just now i setup mutt and learned a bit about
> sending reply to the emails and V2 patch was already validated that's why i submitted it.

It's okay. Just please try not to do it again - it's really an anti-pattern.

> monaco.dtsi already have below node except drive-strength and  bias-pull-up.
> tlmm {
> 	qup_i2c0_data_clk: qup-i2c0-data-clk-state {
> 		pins = "gpio17", "gpio18";
> 		function = "qup0_se0";
> 	};
> };
> I will add drive-strength and  bias-pull-up in monaco-evk.dts, let me know if this is ok?

That should be fine. Other SoC DTSIs do that already

Konrad