Re: [PATCH v1] ASoC: ops: fix snd_soc_get_volsw for sx controls

[David Gow]

Le 16/12/2025 à 9:49 PM, Stefan Binding a écrit :
> SX controls are currently broken, since the clamp introduced in
> commit a0ce874cfaaa ("ASoC: ops: improve snd_soc_get_volsw") does not
> handle SX controls, for example where the min value in the clamp is
> greater than the max value in the clamp.
>
> Add clamp parameter to prevent clamping in SX controls.
> The nature of SX controls mean that it wraps around 0, with a variable
> number of bits, therefore clamping the value becomes complicated and
> prone to error.
>
> Fixes 35 kunit tests for soc_ops_test_access.
>
> Fixes: a0ce874cfaaa ("ASoC: ops: improve snd_soc_get_volsw")
>
> Co-developed-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Stefan Binding <sbinding@xxxxxxxxxxxxxxxxxxxxx>
> ---

Thanks very much: I've just bisected those failures to the same patch, 
so am definitely keen to see this fixed.

Tested-by: David Gow <david@xxxxxxxxxxxx>

Cheers,
-- David