RE: [PATCH] HID: intel-ish-hid: loader: Add PRODUCT_FAMILY-based firmware matching

[Zhang, Lixu]

>-----Original Message-----
>From: srinivas pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
>Sent: Thursday, December 18, 2025 11:55 PM
>To: Vishnu Sankar <vishnuocv@xxxxxxxxx>; jikos@xxxxxxxxxx;
>bentiss@xxxxxxxxxx; Sankar, Vishnu <vsankar@xxxxxxxxxx>; Zhang, Lixu
><lixu.zhang@xxxxxxxxx>; Xu, Even <even.xu@xxxxxxxxx>
>Cc: linux-input@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Mark Pearson
><mpearson-lenovo@xxxxxxxxx>; Richie Roy Jayme <rjayme.jp@xxxxxxxxx>
>Subject: Re: [PATCH] HID: intel-ish-hid: loader: Add PRODUCT_FAMILY-based
>firmware matching
>
>+ Lixu
>+ Even
>
>
>On Thu, 2025-12-18 at 23:00 +0900, Vishnu Sankar wrote:
>> Add support for firmware filenames that include the CRC32 checksum of
>> the DMI product_family field. Several OEMs ship ISH firmware variants
>> shared across a product family while product_name or product_sku may
>> differ.
>> This
>> intermediate matching granularity reduces duplication and improves
>> firmware selection for vendor-customized platforms.

...

>> +
>> +	if (sys_vendor && product_family) {
>> +		snprintf(filename, sizeof(filename),
>> +			 ISH_FW_FILE_VENDOR_FAMILY_FMT,
>> +			 gen, vendor_crc, family_crc);
>> +		ret = _request_ish_firmware(firmware_p, filename,
>> dev);
>> +		if (!ret)
>> +			return 0;
>> +}
Indent issue.

Hi Vishnu,
Thanks for your patch.
1. Please run the ` ./scripts/checkpatch.pl --strict --codespell [PATCH FILE]`, and fix the issue.
2. Could you please also update the document `Documentation/hid/intel-ish-hid.rst`?

Thanks,
Lixu

>>
>>  	if (sys_vendor && product_name && product_sku) {
>>  		snprintf(filename, sizeof(filename),
>> ISH_FW_FILE_VENDOR_NAME_SKU_FMT, gen,