Re: [PATCH v3 2/2] hwmon: temperature: add support for EMC1812

[Guenter Roeck]

On 12/18/25 05:48, Marius Cristea wrote:
> This is the devicetree schema for Microchip EMC1812/13/14/15/33
> Multichannel Low-Voltage Remote Diode Sensor Family.
>
> EMC1812 has one external remote temperature monitoring channel.
> EMC1813 has two external remote temperature monitoring channels.
> EMC1814 has three external remote temperature monitoring channels and
> channels 2 and 3 supports anti parallel diode.
> EMC1815 has four external remote temperature monitoring channels and
> channels 1/2  and 3/4 supports anti parallel diode.
> EMC1833 has two external remote temperature monitoring channels and
> channels 1 and 2 supports anti parallel diode.
>
> Signed-off-by: Marius Cristea <marius.cristea@xxxxxxxxxxxxx>

A quick module test run shows:

temp1_crit_alarm: bad permissions: -rw-r--r--, expected -r--r--r--
temp1_input: bad permissions: -rw-r--r--, expected -r--r--r--
temp1_max_alarm: bad permissions: -rw-r--r--, expected -r--r--r--
temp1_max_hyst: bad permissions: -rw-r--r--, expected -r--r--r--
temp1_min_alarm: bad permissions: -rw-r--r--, expected -r--r--r--
temp1_min_hyst: bad permissions: -rw-r--r--, expected -r--r--r--

for all alarms and temperature readings. Indeed, the driver
sets that. Please fix.

Also, I get

temp1_crit: Deviation out of range [max 500, seen 800 (val=-64000) with -63200]
temp1_crit_hyst: Deviation out of range [max 500, seen 800 (val=-64000) with -63200]
temp1_min: Deviation out of range [max 500, seen 800 (val=-64000) with -63200]
temp1_max: Deviation out of range [max 500, seen 800 (val=-64000) with -63200]
temp2_crit: Deviation out of range [max 500, seen 800 (val=-64000) with -63200]
temp2_crit_hyst: Suspected underflow: [min=-74000, read -64000, written -2147483648]
temp3_crit: Deviation out of range [max 500, seen 800 (val=-64000) with -63200]
temp3_crit_hyst: min [-64000] is equal to max [-64000]

I'll need to track that down unless you find the probem before I do.

Thanks,
Guenter