Re: [PATCH v1] phy: fsl-imx8mq-usb: Fix PCS_TX_SWING_FULL register configuration
From: Fabio Estevam
Date: Thu Dec 18 2025 - 13:44:13 EST
Hi Stefano,
On Thu, Dec 18, 2025 at 2:50 PM Stefano Radaelli
<stefano.radaelli21@xxxxxxxxx> wrote:
>
> Clear the PCS_TX_SWING_FULL field mask before setting the new value
> in PHY_CTRL5 register. Without clearing the mask first, the OR operation
> could leave previously set bits, resulting in incorrect
> register configuration.
The change looks good to me, but the Subject is a bit misleading.
It gives the impression that PCS_TX_SWING_FULL is a register.
What about:
phy: fsl-imx8mq-usb: Clear the PCS_TX_SWING_FULL field before using it