Re: [PATCH 5/5] usb: ohci-nxp: clean up probe error labels

[Johan Hovold]

On Thu, Dec 18, 2025 at 10:09:52AM -0500, Alan Stern wrote:
> On Thu, Dec 18, 2025 at 03:19:45PM +0100, Johan Hovold wrote:
> > Error labels should be named after what they do rather than after from
> > where they are jumped to.
> > 
> > Rename the probe error labels for consistency and to improve
> > readability.
> > 
> > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> > ---
> 
> Johan, in the 3/5 patch you also changed a statement label, which was 
> not directly related to that patch's actual purpose, but it is directly 
> related to this one's.  Can you move that rename from that patch to this 
> one?

Sure. The label "fail_disable" didn't make any sense to me but looking
at the driver again now I see that it's named after the usb_disabled()
check and the rename could indeed be done as part of this patch.

I'll address this in a v2.

Johan