Re: [PATCH] gpio: realtek-otto: use unsigned long

[Bartosz Golaszewski]

On Wed, Dec 17, 2025 at 11:55 PM Rosen Penev <rosenp@xxxxxxxxx> wrote:
>
> On Wed, Dec 17, 2025 at 2:52 PM David Laight
> <david.laight.linux@xxxxxxxxx> wrote:
> >
> > On Wed, 17 Dec 2025 12:23:31 -0800
> > Rosen Penev <rosenp@xxxxxxxxx> wrote:
> >
> > > Fixes compilation on 64-bit platforms as pointers need a larger type.
> >
> > Not a good description...
> >
> > >
> > > Change device_get_match_data to of variant. The data is obtained through
> > > OF anyway.
> > >
> > > Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> > > ---
> > >  drivers/gpio/gpio-realtek-otto.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpio/gpio-realtek-otto.c b/drivers/gpio/gpio-realtek-otto.c
> > > index e6694d5d1696..e9c89b191989 100644
> > > --- a/drivers/gpio/gpio-realtek-otto.c
> > > +++ b/drivers/gpio/gpio-realtek-otto.c
> > > @@ -360,7 +360,7 @@ static int realtek_gpio_probe(struct platform_device *pdev)
> > >       struct gpio_generic_chip_config config;
> > >       struct device *dev = &pdev->dev;
> > >       unsigned long gen_gc_flags;
> > > -     unsigned int dev_flags;
> > > +     unsigned long dev_flags;
> >
> > You don't need to change the type of the variable, just the cast.
> Previous review was:
>
> Just make dev_flags an unsigned long and cast
> device_get_match_data(dev) to uintptr_t.
>

And you still cast it to unsigned long instead. Nevermind, my tree is
broken now due to the warning from picking up the COMPILE_TEST=y patch
so I need to fix it. I'm queuing this as well with some changes to the
commit message and the cast.

Bart