Re: [PATCH 1/5] staging: iio: ad9832: clean up whitespace

From: Marcelo Schmitt

Date: Thu Dec 18 2025 - 09:25:40 EST


Hi Tomas,

LGTM.
One minor suggestion.

On 12/15, Tomas Borquez wrote:
> Remove unnecessary blank lines between comment sections to improve
> readability.
>
> Signed-off-by: Tomas Borquez <tomasborquez13@xxxxxxxxx>
> ---
> drivers/staging/iio/frequency/ad9832.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
> index e2ad3e5a7a..00813dab7c 100644
> --- a/drivers/staging/iio/frequency/ad9832.c
> +++ b/drivers/staging/iio/frequency/ad9832.c
> @@ -26,7 +26,6 @@
> #include "dds.h"
>
> /* Registers */
> -
> #define AD9832_FREQ0LL 0x0
> #define AD9832_FREQ0HL 0x1
> #define AD9832_FREQ0LM 0x2
> @@ -50,7 +49,6 @@
> #define AD9832_OUTPUT_EN 0x13

There is a blank line between AD9832_PHASE3H and AD9832_PHASE_SYM that could
also be removed, IMO.
#define AD9832_PHASE3L 0xE
#define AD9832_PHASE3H 0xF
-
#define AD9832_PHASE_SYM 0x10
#define AD9832_FREQ_SYM 0x11

>
> /* Command Control Bits */
> -
> #define AD9832_CMD_PHA8BITSW 0x1